ci: Fix Windows release attestation by writing CRLF checksums#571
Open
beekld wants to merge 2 commits into
Open
ci: Fix Windows release attestation by writing CRLF checksums#571beekld wants to merge 2 commits into
beekld wants to merge 2 commits into
Conversation
keelerm84
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows release jobs fail at
actions/attest: its parser splitschecksums.txtonos.EOL('\r\n'on Windows), but the Generate-checksums step writes LF-only. The whole file becomes a single record whose subject name exceeds 256 chars.Pipe through
sed 's/$/\r/'on the Windows branch to produce CRLF. Linux and macOS unchanged.Confirmed on a Windows runner:
sha256sumon Git Bash writes LF only, the base64 round-trip preserves it, and Nodeos.EOLon the runner is"\r\n".Note
Low Risk
CI-only line-ending tweak on the Windows checksum branch; no runtime SDK or security logic changes.
Overview
Fixes Windows release jobs failing at
actions/attestwhen parsingchecksums.txt.On the Windows matrix leg, the Generate checksums file step now pipes decoded hashes through
sed 's/$/\r/'so each line ends with CRLF, matching howactions/attestsplits onos.EOL(\r\n) on Windows. LF-only output was treated as one record and blew past subject name limits. Linux and macOS checksum generation is unchanged.The same one-line change is applied everywhere that Windows hash output is written:
manual-sdk-release-artifacts.ymland four release jobs inrelease-please.yml(client, server, redis, dynamodb).Reviewed by Cursor Bugbot for commit 840d153. Bugbot is set up for automated code reviews on this repo. Configure here.